Normalize EOL before diff #335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So you found that nearly all the tests fail with autocrlf enabled. The only reason I can think of this happening is we are somehow inserting our own newlines into the content. I think this is a problem in of itself and we should investigate and fix that. In that case, this change could be masking a problem. Once that is addressed, should this go in? I'm mixed.
I think my preference is still towarsds editorconfig and maybe gitattribute. |
|
You're right, this normalization shouldn't be done on the test, but on the generated files |
|
I'm sorry that solving this hasn't been as straightforward as this originally seemed :( |
|
Don't worry, it's the correct decision ^^ That's why reviews are for ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most of the tests, see #241 for the remaining failing tests