Skip to content

catalog/externalcatalog: delete namespace entries during clean up #140564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Feb 6, 2025

Previously, the external catalog logic would never clean up namespace entries for descriptors when DropIngestedExternalCatalog was invoked. This would lead to left over junk in the system.namespace table, contrary to the normal object deletion protocol. To address this, this patch also deletes namespace entries.

Fixes: #140551

Release note: None

Previously, the external catalog logic would never clean up namespace
entries for descriptors when DropIngestedExternalCatalog was invoked.
This would lead to left over junk in the system.namespace table,
contrary to the normal object deletion protocol. To address this, this
patch also deletes namespace entries.

Fixes: cockroachdb#140551

Release note: None
@fqazi fqazi requested review from msbutler and a team February 6, 2025 03:48
@fqazi fqazi requested a review from a team as a code owner February 6, 2025 03:48
Copy link

blathers-crl bot commented Feb 6, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@fqazi fqazi added the backport-25.1.x Flags PRs that need to be backported to 25.1 label Feb 6, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof. Nice find!

@msbutler
Copy link
Collaborator

msbutler commented Feb 6, 2025

borsing asap to reduce flakiness

bors r+

@fqazi
Copy link
Collaborator Author

fqazi commented Feb 6, 2025

@msbutler TFTR

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 6, 2025

Already running a review

@craig craig bot merged commit 0b98fd7 into cockroachdb:master Feb 6, 2025
22 checks passed
Copy link

blathers-crl bot commented Feb 6, 2025

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #140551: branch-release-25.1.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Copy link

blathers-crl bot commented Feb 6, 2025

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-25.1-140564 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/140594/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 25.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-25.1.x Flags PRs that need to be backported to 25.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql/catalog/externalcatalog: TestExtractIngestExternalCatalog failed
3 participants