-
Notifications
You must be signed in to change notification settings - Fork 3.9k
release-25.1: mixedversion: add MinBootstrapVersion option #143006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DarrylWong
merged 3 commits into
release-25.1
from
blathers/backport-release-25.1-142211
Apr 3, 2025
Merged
release-25.1: mixedversion: add MinBootstrapVersion option #143006
DarrylWong
merged 3 commits into
release-25.1
from
blathers/backport-release-25.1-142211
Apr 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows test writers to set a MinBootstrapVersion. This option will tell to the mixed version framework to not generate any plans that create a cluster on any versions older than MinBootstrapVersion.
…rades Previously, mixed versions tests that required the cluster to be started within a certain version would set the MaxUpgrades option. This works but will rot every time we advance versions. Instead this change switches those tests to use MinimumBootstrapVersion instead. Additionally the http-register-routes/mixed-versions test now sets the MinBootstrapVersion to 24.2, the oldest release that has the fix contained in #138342
7288e7d
to
f278b15
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
srosenberg
approved these changes
Apr 2, 2025
herkolategan
approved these changes
Apr 3, 2025
Recently, this test started running with more workload steps, each of which takes 5min, so it's been timing out consistently. This commit increases the test timeout to 3 hours. Fixes: #143331 Release note: None
Cherry picked #143661 on top |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
backport-test-only
Used to denote the backport has only non-production changes
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
v25.1.6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #142211 on behalf of @DarrylWong.
/cc @cockroachdb/release
This change allows test writers to set a MinBootstrapVersion. This option will tell to the mixed version framework to not generate any plans that create a cluster on any versions older than MinBootstrapVersion.
With this new option, the
http-register-routes/mixed-versions
test now sets the MinBootstrapVersion to 24.2, the oldest release that has the fix contained in #138342.Fixes: #138861
Release note: none
Closes: #139410
Release justification: Test only change