backup: add checkpointing to backup compactions #143849
Merged
+142
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
kev-cao
force-pushed
the
backup/compaction-checkpointing
branch
4 times, most recently
from
b6b21ae to
ef63425
Compare
kev-cao
force-pushed
the
backup/compaction-checkpointing
branch
4 times, most recently
from
96b9623 to
8300774
Compare
msbutler
reviewed
Apr 7, 2025
kev-cao
force-pushed
the
backup/compaction-checkpointing
branch
from
8300774 to
ffd6abf
Compare
msbutler
reviewed
Apr 7, 2025
kev-cao
force-pushed
the
backup/compaction-checkpointing
branch
from
ffd6abf to
5601aef
Compare
This patch adds periodic checkpointing to backup compaction jobs. Epic: None Release note: None
kev-cao
force-pushed
the
backup/compaction-checkpointing
branch
from
5601aef to
c4f7fce
Compare
msbutler
approved these changes
Apr 8, 2025
|
TFTR! bors r=msbutler |
craig bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
143849: backup: add checkpointing to backup compactions r=msbutler a=kev-cao This patch adds periodic checkpointing to backup compaction jobs. Epic: None Release note: None 143985: backup: checkpoint after online restore link phase r=msbutler a=msbutler This patch will prevent online restore from rerunning the link flow if it has already completed. This will be useful for restore with experimental copy, which runs the download phase in the same job as the link phase. At some point in the future, we could add finer grain checkpointing to the link phase, but that would require more work and thought. Epic: none Release note: none 144000: orchestration: released CockroachDB version 25.1.3. Next version: 25.1.4 r=celiala a=cockroach-teamcity Release note: None Epic: None Release justification: non-production (release infra) change. 144037: sql/stats: bring back guard against non-zero NumRange in forecasts r=yuzefovich a=michae2 It occurred to me tonight that the code we removed in #143955 not only generated a sentry report, but also returned an error instead of producing a faulty histogram. I too hope that #93892 is now fixed, but it seems wise to at least keep some code that guards against faulty histograms, even if we don't think the sentry report is necessary any more. Informs: #93892 Epic: None Release note: None 144050: dr: alias streaming replication to PCR r=msbutler a=ajstorm Add an alias in the original Streaming Replication Between Clusters RFC to PCR, for easier discovery. I can see an argument for not merging this, as the original RFC might not bare resemblance to what was built in the end, but the RFC is basically undiscoverable today due to its antiquated naming. Epic: none Release note: None 144088: ci: prioritize `staging-*` builds higher r=jlinder a=rickystewart These builds are high-priority backports and we want them to get through the queue as quickly as possible. Epic: DEVINF-1449 Release note: None Co-authored-by: Kevin Cao <[email protected]> Co-authored-by: Michael Butler <[email protected]> Co-authored-by: Justin Beaver <[email protected]> Co-authored-by: Michael Erickson <[email protected]> Co-authored-by: Adam Storm <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds periodic checkpointing to backup compaction jobs.
Epic: None
Release note: None