Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-25.1: explain: show "execution time" on EXPLAIN ANALYZE output #143895

Merged

Conversation

yuzefovich
Copy link
Member

Backport 1/1 commits from #143857.

/cc @cockroachdb/release


We've been tracking "execution time" statistic for most operators (except for vectorized KV-reading ones which get separate "KV time" stat) for many years now, but for some reason we only reported it on the DistSQL diagram. This commit fixes that oversight so that the stat is now included on EXPLAIN ANALYZE output when available.

Fixes: #143443.

Release note (sql change): New statistic execution time is now reported on EXPLAIN ANALYZE output for most operators. It was previously only available on the DistSQL diagrams (included in EXPLAIN ANALYZE (DISTSQL) output).

Release justification: low-risk observability improvement.

@yuzefovich yuzefovich requested a review from michae2 April 3, 2025 17:22
@yuzefovich yuzefovich requested a review from a team as a code owner April 3, 2025 17:22
Copy link

blathers-crl bot commented Apr 3, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 3, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich force-pushed the backport25.1-143857 branch from ba70c1e to c5bb92c Compare April 3, 2025 17:30
Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @michae2)

We've been tracking "execution time" statistic for most operators
(except for vectorized KV-reading ones which get separate "KV time"
stat) for many years now, but for some reason we only reported it on
the DistSQL diagram.  This commit fixes that oversight so that the
stat is now included on `EXPLAIN ANALYZE` output when available.

Release note (sql change): New statistic `execution time` is now
reported on EXPLAIN ANALYZE output for most operators. It was
previously only available on the DistSQL diagrams (included in
`EXPLAIN ANALYZE (DISTSQL)` output).
@yuzefovich yuzefovich force-pushed the backport25.1-143857 branch from c5bb92c to 1b775d4 Compare April 7, 2025 23:33
@yuzefovich yuzefovich merged commit 4d3e09c into cockroachdb:release-25.1 Apr 8, 2025
15 of 16 checks passed
@yuzefovich yuzefovich deleted the backport25.1-143857 branch April 8, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches target-release-25.1.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants