Skip to content

release-25.2: roachtest: fix unsortedMatricesDiffWithFloatComp helper for numerics #147229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented May 23, 2025

Backport 1/1 commits from #147051 on behalf of @yuzefovich.


This commit is similar in spirit to 261cae9. We use T_numeric and T__numeric oids for decimals and decimal arrays, respectively. These oids have "NUMERIC" and "_NUMERIC" names in lib/pq when stringified, so we need to teach our custom logic for ignoring trailizing zeroes to also apply whenever it sees the numeric column types.

Fixes: #146524.

Release note: None


Release justification: test-only change.

This commit is similar in spirit to
261cae9. We use `T_numeric` and
`T__numeric` oids for decimals and decimal arrays, respectively. These
oids have "NUMERIC" and "_NUMERIC" names in lib/pq when stringified, so
we need to teach our custom logic for ignoring trailizing zeroes to also
apply whenever it sees the numeric column types.

Release note: None
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 23, 2025
@blathers-crl blathers-crl bot requested a review from rytaft May 23, 2025 17:24
Copy link

blathers-crl bot commented May 23, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 23, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added backport-failed backport-test-only Used to denote the backport has only non-production changes and removed backport-failed labels May 23, 2025
@yuzefovich yuzefovich merged commit c616af2 into cockroachdb:release-25.2 May 24, 2025
24 of 25 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-25.2-147051 branch May 24, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-25.2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants