Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-12504 Clarify that the connection latency metric (and chart) does not include failed queries #19416

Merged
merged 9 commits into from
Apr 10, 2025

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Mar 4, 2025

Fixes DOC-12504

In essential-metrics.md, added sql.conn.failures and updated sql.conn.latency.
In ui-sql-dashboard.md, updated text of Connection Latency graphs.
In cockroachcloud/metrics-usage/sql.conn.latency.md, updated text.

Rendered preview

Copy link

github-actions bot commented Mar 4, 2025

Files changed:

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit f50721e
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67f81d401b92f50008aba71d

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit f50721e
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67f81d40e417d8000879941c

Copy link

netlify bot commented Mar 4, 2025

Netlify Preview

Name Link
🔨 Latest commit f50721e
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67f81d40bea4f200086d3297
😎 Deploy Preview https://deploy-preview-19416--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@florence-crl florence-crl changed the title DOC-12504 Clarify that the connection latency metric (and chart) doesn't not include failed queries DOC-12504 Clarify that the connection latency metric (and chart) does not include failed queries Mar 4, 2025
@kevin-v-ngo kevin-v-ngo self-requested a review March 4, 2025 20:08
Copy link

@kevin-v-ngo kevin-v-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@florence-crl florence-crl requested a review from katmayb April 9, 2025 15:25
Copy link
Contributor

@katmayb katmayb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@florence-crl florence-crl merged commit 5c0d008 into main Apr 10, 2025
6 checks passed
@florence-crl florence-crl deleted the DOC-12504 branch April 10, 2025 19:44
florence-crl added a commit that referenced this pull request Apr 11, 2025
katmayb pushed a commit that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants