-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manage PCR page for cluster upgrades + tasks #19472
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
0a7008f
to
257b1fc
Compare
257b1fc
to
59cdae5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - we likely need a small section on the reader tenant behavir, I have tagged @msbutler to add his feedback
@@ -150,7 +150,7 @@ cockroach sql --url `"postgresql://root@{node IP or hostname}:{26257}?options=-c | |||
~~~ | |||
|
|||
{{site.data.alerts.callout_info}} | |||
You can only read data on the created `readonly` virtual cluster, other operations like `SHOW VIRTUAL CLUSTERS` must be run from the `system` virtual cluster. To connect to the `readonly` virtual cluster, refer to the [Connection Reference]({% link {{ page.version.version }}/set-up-physical-cluster-replication.md %}#connection-reference). | |||
You can only read data on the created `readonly` virtual cluster, other operations like `SHOW VIRTUAL CLUSTERS` must be run from the `system` virtual cluster. To connect to the `readonly` virtual cluster, refer to the [Connection Reference]({% link {{ page.version.version }}/manage-physical-cluster-replication.md %}#connection-reference). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts on getting super specific here when we talk about 'reading data?' Personally I think 'read' is good enough, but some of the engineers think that we should explicitly say SELECT from standby. But the user can also run SHOW TABLES or something. So maybe 'read' is good enough.
## Upgrade the cluster version on the primary and standby | ||
|
||
{{site.data.alerts.callout_danger}} | ||
The standby cluster must be at the same version as, or one version ahead of, the primary's virtual cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must always?
Upgrade the binary on **every node** in both the primary and standby clusters: | ||
|
||
1. Replace the `cockroach` binary on each node. | ||
1. Restart CockroachDB each node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - restart cockroachdb on each node?
|
||
### Step 2. Finalize the upgrade on each virtual cluster | ||
|
||
You must finalize the upgrade on each virtual cluster in this order: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msbutler We need to add a note here on what to do with the readonly virtual cluster, can you provide a line here for that?
Fixes DOC-12355, DOC-11810