Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manage PCR page for cluster upgrades + tasks #19472

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

katmayb
Copy link
Contributor

@katmayb katmayb commented Mar 26, 2025

Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 59cdae5
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67ebec99e378790008c91faa

Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 59cdae5
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67ebec995d4e50000806c1f3

Copy link

netlify bot commented Mar 26, 2025

Netlify Preview

Name Link
🔨 Latest commit 59cdae5
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67ebec9955b42000082d0376
😎 Deploy Preview https://deploy-preview-19472--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@katmayb katmayb force-pushed the pcr-cluster-upgrade-version branch from 0a7008f to 257b1fc Compare March 31, 2025 20:12
@katmayb katmayb force-pushed the pcr-cluster-upgrade-version branch from 257b1fc to 59cdae5 Compare April 1, 2025 13:39
@katmayb katmayb requested review from msbutler and removed request for msbutler April 7, 2025 15:42
Copy link

@alicia-l2 alicia-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we likely need a small section on the reader tenant behavir, I have tagged @msbutler to add his feedback

@@ -150,7 +150,7 @@ cockroach sql --url `"postgresql://root@{node IP or hostname}:{26257}?options=-c
~~~

{{site.data.alerts.callout_info}}
You can only read data on the created `readonly` virtual cluster, other operations like `SHOW VIRTUAL CLUSTERS` must be run from the `system` virtual cluster. To connect to the `readonly` virtual cluster, refer to the [Connection Reference]({% link {{ page.version.version }}/set-up-physical-cluster-replication.md %}#connection-reference).
You can only read data on the created `readonly` virtual cluster, other operations like `SHOW VIRTUAL CLUSTERS` must be run from the `system` virtual cluster. To connect to the `readonly` virtual cluster, refer to the [Connection Reference]({% link {{ page.version.version }}/manage-physical-cluster-replication.md %}#connection-reference).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on getting super specific here when we talk about 'reading data?' Personally I think 'read' is good enough, but some of the engineers think that we should explicitly say SELECT from standby. But the user can also run SHOW TABLES or something. So maybe 'read' is good enough.

## Upgrade the cluster version on the primary and standby

{{site.data.alerts.callout_danger}}
The standby cluster must be at the same version as, or one version ahead of, the primary's virtual cluster.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must always?

Upgrade the binary on **every node** in both the primary and standby clusters:

1. Replace the `cockroach` binary on each node.
1. Restart CockroachDB each node.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - restart cockroachdb on each node?


### Step 2. Finalize the upgrade on each virtual cluster

You must finalize the upgrade on each virtual cluster in this order:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msbutler We need to add a note here on what to do with the readonly virtual cluster, can you provide a line here for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants