chore: review updates

Signed-off-by: Anush008 <[email protected]>

Author: Anush008

docs/docs/ops/storages.md

@@ -11,16 +11,16 @@ description: CocoIndex Built-in Storages
 
 The spec takes the following fields:
 
-* `database_url` (type: `str`, optional): The URL of the Postgres database to use as the internal storage, e.g. `postgres://cocoindex:cocoindex@localhost/cocoindex`. If unspecified, will use the same database as the [internal storage](/docs/core/basics#internal-storage).
+*   `database_url` (type: `str`, optional): The URL of the Postgres database to use as the internal storage, e.g. `postgres://cocoindex:cocoindex@localhost/cocoindex`. If unspecified, will use the same database as the [internal storage](/docs/core/basics#internal-storage).
 
-* `table_name` (type: `str`, optional): The name of the table to store to. If unspecified, will generate a new automatically. We recommend specifying a name explicitly if you want to directly query the table. It can be omitted if you want to use CocoIndex's query handlers to query the table.
+*   `table_name` (type: `str`, optional): The name of the table to store to. If unspecified, will generate a new automatically. We recommend specifying a name explicitly if you want to directly query the table. It can be omitted if you want to use CocoIndex's query handlers to query the table.
 
 ## Qdrant
 
 `Qdrant` exports data to a [Qdrant](https://qdrant.tech/) collection.
 
 The spec takes the following fields:
 
-* `qdrant_url` (type: `str`, required): The [gRPC URL](https://qdrant.tech/documentation/interfaces/#grpc-interface) of the Qdrant instance. Defaults to <http://localhost:6334/>.
+*   `qdrant_url` (type: `str`, required): The [gRPC URL](https://qdrant.tech/documentation/interfaces/#grpc-interface) of the Qdrant instance. Defaults to http://localhost:6334/.
 
-* `collection` (type: `str`, required): The name of the collection to export the data to.
+*   `collection` (type: `str`, required): The name of the collection to export the data to.

src/ops/storages/qdrant.rs

@@ -70,12 +70,10 @@ impl ExportTargetExecutor for Executor {
     async fn apply_mutation(&self, mutation: ExportTargetMutation) -> Result<()> {
         let mut points: Vec<PointStruct> = Vec::with_capacity(mutation.upserts.len());
         for upsert in mutation.upserts.iter() {
-            let key_fields = key_value_fields_iter(&self.key_fields_schema, &upsert.key)?
-                .iter()
-                .collect();
-            let key_fields = parse_key_fields(&key_fields, &self.key_fields_schema)?;
+            let key_fields = key_value_fields_iter(&self.key_fields_schema, &upsert.key)?;
+            let key_fields = key_values_to_payload(&key_fields, &self.key_fields_schema)?;
             let (mut payload, vectors) =
-                parse_value_fields(&upsert.value.fields, &self.value_fields_schema)?;
+                values_to_payload(&upsert.value.fields, &self.value_fields_schema)?;
             payload.extend(key_fields);
 
             points.push(PointStruct::new(1, vectors, payload));
@@ -88,8 +86,8 @@ impl ExportTargetExecutor for Executor {
     }
 }
 
-fn parse_key_fields(
-    key_fields: &Vec<&KeyValue>,
+fn key_values_to_payload(
+    key_fields: &[KeyValue],
     schema: &Vec<FieldSchema>,
 ) -> Result<HashMap<String, QdrantValue>> {
     let mut payload = HashMap::with_capacity(key_fields.len());
@@ -117,7 +115,7 @@ fn parse_key_fields(
     Ok(payload)
 }
 
-fn parse_value_fields(
+fn values_to_payload(
     value_fields: &Vec<Value>,
     schema: &Vec<FieldSchema>,
 ) -> Result<(HashMap<String, QdrantValue>, NamedVectors)> {