problem with canvas2d #3275
Open
problem with canvas2d #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner fileNode have loop animation and main fileNode have animation change color.If play animation which change color without loop, inner FileNode have problem with no rotated image in atlas only in Canvas2d in webgl works normal (example with cocos2d-html5 v.11:http://mab.to/eo7YoVAs9)
| @@ -201,8 +201,10 @@ | |||
| textureLoaded = textureLoaded || pNewTexture._textureLoaded; | |||
| if (textureLoaded) { | |||
| var curColor = this._node.getColor(); | |||
| if (curColor.r !== 255 || curColor.g !== 255 || curColor.b !== 255) | |||
| if (curColor.r !== 255 || curColor.g !== 255 || curColor.b !== 255|| | |||
| this._displayedColor.r !== 255 || this._displayedColor.g !== 255 || this._displayedColor.b !== 255) { | |||
There was a problem hiding this comment.
I think we should only check displayedColor, we can assume it's always synced or generated with node's color.
|
Thanks for the contribution, can you remove the check for node's color so that I can merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem with canvas2d, when FileNode have other inner fileNode and inner fileNode have loop animation and main fileNode have animation change color. If play animation which change color without loop, inner FileNode have problem with no rotated image in atlas only in Canvas2d in webGL works normal (example with cocos2d-html5 v.11:http://mab.to/eo7YoVAs9)