Fix iCCP profile using mogrify #18908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drelaptop @minggo Can you take alook at it, please? |
|
@v1993 wonderful, thanks for this good patch. I will check it later. |
|
@drelaptop I think we need to add something in doc to mention it. |
|
@slackmoehrle I think we need to add something in doc to mention it. |
|
Tested by TemplateCpp, it truly solved this issue. and I have new a issue for doc requirement cocos2d/cocos2d-x-docs#161 |
|
And do not forget to set the milestone of this PR. |
PatriceJiang
added a commit
to PatriceJiang/cocos2d-x
that referenced
this pull request
Jul 6, 2018
Fix iCCP profile using mogrify (cocos2d#18908)
PatriceJiang
added a commit
to PatriceJiang/cocos2d-x
that referenced
this pull request
Jul 6, 2018
Fix iCCP profile using mogrify (cocos2d#18908)
This was referenced Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get a lot of
libpng warning: iCCP: known incorrect sRGB profileon tests/templates.This PR should fix it. For more information, refer to https://stackoverflow.com/a/22747902/5697743.