Fix animation duration calculation #19221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The duration of action will be miscalculated when float abs(float) is unavailble, replacing it with std::abs fixes the issue.
Could you please provide more info about how would this occur? @LuoJinghua |
|
I'm sorry, I accidently closed the pull request.
assume |d| < 1.0f and float abs(float) is absent,
will evaluate to
which is wrong, it should be d instead. There is no float abs(float) in stdlib.h1 at least on linux.
|
PatriceJiang
approved these changes
Nov 30, 2018
|
It dose trigger a compile warning message on Linux with |
stevetranby
added a commit
to stevetranby/cocos2d-x
that referenced
this pull request
Dec 3, 2018
* commit 'ed2eab52973eb614e14f6680b9c0bbd315b017a5': Fix animation duration calculation (cocos2d#19221) Simplify install-deps-linux.sh, tested on Ubuntu 16.04 (cocos2d#19212) Switch travis CI to xenial (cocos2d#19207) add testcase for lua downloader binding (cocos2d#19182) # Conflicts: # tests/lua-tests/src/mainMenu.lua
huangwei1024
pushed a commit
to huangwei1024/cocos2d-x
that referenced
this pull request
Jun 20, 2019
The duration of action will be miscalculated when float abs(float) is unavailble, replacing it with std::abs fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duration of action will be miscalculated when float abs(float)
is unavailble, replacing it with std::abs fixes the issue.