Skip to content

Add subnet parent test #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

cmeissner
Copy link
Member

As there is some work needed in managing subnets and/or folders and its
parents a test case is needed.
For that purpose we added a test playbook and a needed variable for
example data.
We also fix a bug in the subnet task to.
With all these changes/additions we can test subenets and parent subnets
first. In later steps we need to extend the test to also check the
majority of all combinations of subnets, folders and parents.

As there is some work needed in managing subnets and/or folders and its
parents a test case is needed.
For that purpose we added a test playbook and a needed variable for
example data.
We also fix a bug in the `subnet` task to.
With all these changes/additions we can test subenets and parent subnets
first. In later steps we need to extend the test to also check the
majority of all combinations of subnets, folders and parents.
@cmeissner cmeissner self-assigned this Aug 25, 2023
@cmeissner cmeissner added the enhancement New feature or request label Aug 25, 2023
@cmeissner cmeissner requested a review from gmzabos August 25, 2023 11:35
Copy link
Member

@gmzabos gmzabos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmeissner cmeissner merged commit 0a49834 into codeaffen:develop Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants