Adding support for attaching screenshots to cucumberJsonReporter #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arhell
approved these changes
Apr 27, 2021
|
I looked at the details and it doesn't feel related to the change I made. Not sure how to trigger another build w/o a new commit. |
|
The PR seems valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
This PR is the partner to a PR in
codecept-cucumber-json-reporterwhich will enable embedding of screenshots in Cucumber JSON when it has been specified as a pluginApplicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)