Skip to content

fix: switchTo - within block #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 9, 2023
Merged

fix: switchTo - within block #3892

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cbb069c
fix: switchTo
kobenguyent Sep 26, 2023
c27a955
Merge branch '3.x' into fix-switchTo
kobenguyent Sep 26, 2023
9a2e3ba
fix: switch to
kobenguyent Sep 30, 2023
d067ae7
fix: failed acceptance tests
kobenguyent Sep 30, 2023
8004bee
fix: within block
kobenguyent Sep 30, 2023
c69dd1c
fix: within tests
kobenguyent Sep 30, 2023
70cc4d4
fix: within tests
kobenguyent Sep 30, 2023
8b1ad76
fix: within tests
kobenguyent Sep 30, 2023
4bd0ed9
fix: within block
kobenguyent Oct 4, 2023
81e4fbe
fix within block
kobenguyent Oct 4, 2023
e9f45a1
fix switchTo
kobenguyent Oct 4, 2023
7fa87ca
fix: puppeteer test
kobenguyent Oct 4, 2023
5af37df
fix: switchTo
kobenguyent Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/helper/Playwright.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2558,7 +2558,7 @@ class Playwright extends Helper {

// get content of the first iframe
locator = new Locator(locator, 'css');
if ((locator.frame && locator.frame === 'iframe') || locator.value.toLowerCase() === 'iframe') {
if ((locator.frame && locator.frame === 'iframe') || locator.value.toLowerCase() === 'iframe' || locator.value.toLowerCase().includes('iframe')) {
contentFrame = await this.page.frames()[1];
// get content of the iframe using its name
} else if (locator.value.toLowerCase().includes('name=')) {
Expand Down
7 changes: 7 additions & 0 deletions test/helper/Playwright_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,13 @@ describe('Playwright', function () {
I.switchTo(null);
I.see('Iframe test');
});

it('should switch to iframe using css', async () => {
I.amOnPage('/iframe');
I.switchTo('iframe#number-frame-1234');
I.see('Information');
I.see('Lots of valuable data here');
});
});

describe('#seeInSource, #grabSource', () => {
Expand Down