Skip to content

fixing that testgrep gets ignored when --verbose is set #3901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fixing that testgrep gets ignored when --verbose is set #3901

wants to merge 1 commit into from

Conversation

d9r-dev
Copy link

@d9r-dev d9r-dev commented Oct 1, 2023

Motivation/Description of the PR

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent
Copy link
Collaborator

I noticed we have this fix #3882 may this also resolve your issue?

@d9r-dev
Copy link
Author

d9r-dev commented Oct 1, 2023 •
edited
Loading

I noticed we have this fix #3882 may this also resolve your issue?

I am not sure, I will have a look into it.

@d9r-dev
Copy link
Author

d9r-dev commented Oct 1, 2023

This Pull Request fixes the issue. Therfore I will close this PR.

@d9r-dev d9r-dev closed this Oct 1, 2023
@d9r-dev d9r-dev deleted the fix-verbose-ignoring-testgrep branch October 1, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testgrep not working with --verbose flag
2 participants
@d9r-dev @kobenguyent