-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parallel execution by workers on multiple browsers results with multiple output folders #3971
Conversation
lib/workers.js
Outdated
collection.createRuns(selectedRuns, config).forEach((worker) => { | ||
const _config = { ...config }; | ||
_config.output = `${currentOutputFolder}/${worker.config.browser.browser}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe ${worker.name}
is better than ${worker.config.browser.browser}
Then an output folder name will be e.g. personal:chromium1
(or dev:chromium1
) instead of chromium
and it's more similar to naming when using run-multiple
mode.
The run-multiple
mode uses personal_chromium_1
(<profile>_<browser_name>_<browser_order>
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help tell what worker.name returns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run a test in VSCode in debug mode and just saw the value. I guess "worker.name" returns <profile_name>:<browser_name>1
.
Not sure for 1
means. I thought that it's a worker ID, but in my testing it's always 1
even for multiple workers (e.g. 2 workers).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your reply!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, folder name is e.g. dev_firefox1
(profile "dev", browser "firefox") after the latest fixes ✔️ .
Also XML report result.xml
is stored to a folder per browser ✔️ .
Motivation/Description of the PR
Type of change
Checklist:
npm run docs
)npm run lint
)npm test
)