fix: Puppeteer helper doc broken link #4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arhell
approved these changes
May 31, 2024
kobenguyent
requested changes
May 31, 2024
There was a problem hiding this comment.
As the .md files are taken care by npm run docs
so please update here
https://github.com/codeceptjs/CodeceptJS/blob/3.x/lib/helper/Puppeteer.js#L2475
https://github.com/codeceptjs/CodeceptJS/blob/3.x/lib/helper/Puppeteer.js#L2480
then run npm run docs to update the documentations.
|
@kobenguyent there is an issue while running 
I installed dependencies (using |
|
Could you try this npm run def && npm run docs |
|
And then running |
well, I think you haven't run |
kobenguyent
approved these changes
Jun 3, 2024
|
Thanks a lot, I removed my The PR is updated with your feedbacks. Thanks a lot for your patience and answering my dumb questions 😄 |
|
No worries @yoannfleurydev 😀 I bumped into the same thing when I first touched the codebase. |
kobenguyent
added a commit
that referenced
this pull request
Jun 7, 2024
* fix(webApi): error message of dontSeeCookie (#4357) * Fixed error message for dontSeeCookie() * fix(cli): gherkin command init with TypeScript (#4366) * DOC: Update contributor faces * fix(doc): Expect helper is not described correctly (#4370) * fix: Puppeteer helper doc typo (#4369) * chore(deps): bump devtools from 8.36.1 to 8.38.0 (#4374) * chore(deps-dev): bump playwright from 1.44.0 to 1.44.1 (#4376) Bumps [playwright](https://github.com/microsoft/playwright) from 1.44.0 to 1.44.1. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.44.0...v1.44.1) --- updated-dependencies: - dependency-name: playwright dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump axios from 1.6.7 to 1.7.2 (#4372) * chore(deps-dev): bump typedoc-plugin-markdown from 3.17.1 to 4.0.3 (#4373) * fix: handle throw error inside retryTo promise * fix: test due to update on retryTo plugin * fix: add a test case succeed after 2 retry --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Arthur Stankevich <[email protected]> Co-authored-by: Ando NARY <[email protected]> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: KobeN <[email protected]> Co-authored-by: Yoann Fleury <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Broken link in puppeteer helper documentation
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)