feat(cli): print failed hooks #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successfully published 3.6.6-beta.5 |
kobenguyent
deleted the
4466-error-handling-suggestion-for-aftersuite-hook
branch
Merged
|
@kobenguyent E.g.
Tested with CodeceptJS 3.6.7 |
kobenguyent
commented
Dec 11, 2024
| @@ -216,8 +217,14 @@ class Cli extends Base { | |||
| console.log(); | |||
| } | |||
|
|
|||
| this.failures.forEach((failure) => { | |||
| if (failure.constructor.name === 'Hook') { | |||
| stats.failures -= stats.failures | |||
There was a problem hiding this comment.
hey @mirao perhaps the failure count should not be touched, just adding failedHooks is good enough. What do you think?
There was a problem hiding this comment.
stats.failures -= stats.failures isn't the same as stats.failures = 0 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
AfterSuiteHook #4466run command
run workers command
Type of change
Checklist:
npm run docs)npm run lint)npm test)