Specify peer dependency on codeceptjs #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Sep 22, 2022
| @@ -31,5 +31,8 @@ | |||
| "mocha": "^8.2.1", | |||
| "puppeteer": "^2.1", | |||
| "webdriverio": "^6.4.2" | |||
| }, | |||
| "peerDependencies": { | |||
| "codeceptjs": ">= 2.3.3" | |||
There was a problem hiding this comment.
version chosen based off of whats in the README: https://github.com/codeceptjs/configure#codeceptjs-configuration-hooks-
Requires CodeceptJS >= 2.3.3
This was referenced Sep 22, 2022
Arhell
approved these changes
Sep 23, 2022
|
Mind checking this one too please @DavertMik ? Thanks! |
|
thank you! |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same issue as codeceptjs/CodeceptJS#3413
Yarn v3 is stricter on dependencies and doesn't allow you to require non listed deps