DRY analyzer specs #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, but did we consider moving these to use the new |
| @@ -0,0 +1,28 @@ | |||
| module AnalyzerSpec | |||
| def self.included(base) | |||
There was a problem hiding this comment.
Would this be better added via RSpec.configure? Maybe on a in_tmpdir: true tag or something?
|
@brynary That's a good idea, but not something I want to do just now: these specs test some other things like readup contents that I don't believe the test harness handles? It would be good to use the test harness & break the other things into different specs, but it's a bigger refactor than I want to get into right now. |
wfleming
force-pushed
the
will/dry-tests
branch
from
97c9d1a to
0a238d3
Compare
|
LGTM |
wfleming
force-pushed
the
will/dry-tests
branch
from
0a238d3 to
a5e1fe9
Compare
These pieces were repeated pretty much verbatim between the different analyzer specs. That seems especially silly since this is, after all, an engine for pointing out code duplication.
wfleming
force-pushed
the
will/dry-tests
branch
from
a5e1fe9 to
e1d2760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These pieces were repeated pretty much verbatim between the different
analyzer specs. That seems especially silly since this is, after all, an
engine for pointing out code duplication.
👀 @codeclimate/review