Don't rescue ThreadError in FileThreadPool #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| yield item | ||
| end | ||
| rescue ThreadError | ||
| while !queue.empty? && item = queue.pop(true) |
There was a problem hiding this comment.
What do you think of using #any? here? If CC were running on this repo, I think it would recommend wrapping the assignment.
while queue.any? && (item = queue.pop(true))There was a problem hiding this comment.
The parens are a very good point. But there is no #any? defined on Queue[http://ruby-doc.org/core-2.2.3/Queue.html].
There was a problem hiding this comment.
Ah, so it doesn't. Thought it might mixin Enumerable, but it doesn't.
|
Just a couple nits. Looks good 👍 |
The previous implementation was blindly catching all ThreadError exceptions, because that's what `#pop(true)` raises when the queue is empty. However, there are other situations that would raise the same class that we definitely shouldn't be silently ignoring. This changes the code to actually check if the queue is empty before popping, and removes the rescue entirely: if exceptions happen, we want to know.
wfleming
force-pushed
the
will/dont-rescue-thread-error
branch
from
6c8c9f5 to
6e6ece7
Compare
wfleming
added a commit
that referenced
this pull request
Dec 18, 2015
Don't rescue ThreadError in FileThreadPool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was blindly catching all ThreadError
exceptions, because that's what
#pop(true)raises when the queue isempty. However, there are other situations that would raise the same
class that we definitely shouldn't be silently ignoring.
This changes the code to actually check if the queue is empty before
popping, and removes the rescue entirely: if exceptions happen, we want
to know.
👀 @codeclimate/review