skip file message: format everything in one call #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that some logs reporting skip file messages seemed to interleave multiple messages: That's not terribly surprising due to concurrency. This changes the message formatting a bit & does it all in one method call to avoid the threading issues.
|
👍 |
wfleming
added a commit
that referenced
this pull request
Dec 29, 2015
skip file message: format everything in one call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some logs reporting skip file messages seemed to
interleave multiple messages: That's not terribly surprising due to
concurrency.
This changes the message formatting a bit & does it all in one method
call to avoid the threading issues.
@codeclimate/review