Emit JSON errors from PHP Parser #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfleming
force-pushed
the
will/json-octet-error
branch
from
53d4f67 to
4ee50f4
Compare
Oh have I got a language for you! |
|
LGTM |
I was waiting for the Haskell reference :) |
The PHP parser had a bug here in that it presumed JSON encoding would succeed (and there are reasons it might not). This checks the return value of `json_encode` and emits a relevant error message if appropriate. Before this, a triggering case would result in empty output and an unhelpful error message from `JSON.parse` upstream in the Ruby code.
wfleming
force-pushed
the
will/json-octet-error
branch
from
4ee50f4 to
6577ca1
Compare
wfleming
added a commit
that referenced
this pull request
Jan 4, 2016
Emit JSON errors from PHP Parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP parser had a bug here in that it presumed JSON encoding would
succeed (and there are reasons it might not). This checks the return
value of
json_encodeand emits a relevant error message ifappropriate. Before this, a triggering case would result in empty output
and an unhelpful error message from
JSON.parseupstream in the Rubycode.
👀 @codeclimate/review
FWIW the triggering code that led me to this was a source file that contained the string ".Inf": PHP's
encode_jsonconsiders that to actually be a reference to the valueINF(Infinity), which isn't a valid JSON value. I'm still looking into what the best remediation for that specific issue might be. My kingdom for a type system that doesn't boil down to "everything is either a string or a map".