Initial Setup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
filipesperandio
commented
Sep 7, 2017
filipesperandio
commented
- Script to install latest PMD bins
- Smaller image
- README
- Remove unecessary files
filipesperandio
force-pushed
the
fe/initial_setup
branch
from
b93b756 to
84e69f4
Compare
gdiggs
reviewed
Sep 7, 2017
Dockerfile
Outdated
| COPY ./bin /usr/src/app/bin | ||
| RUN /usr/src/app/bin/install-pmd.sh | ||
|
|
||
| RUN adduser -u 9000 -D app |
There was a problem hiding this comment.
Can we run this above the COPY line 11 so that it caches better?
Additionally, do you need to chown /usr/src/app?
| cd ${LIB_DIR} | ||
|
|
||
| install_pmd | ||
| cleanup |
There was a problem hiding this comment.
This all seems like it's begging to be a Makefile WDYT?
There was a problem hiding this comment.
@gordondiggs Don't think so. It is only meant to run building the image. I could have all this in the Dockerfile itself but looks ugly.
| --env GCR_JSON_KEY | ||
| --volume /var/run/docker.sock:/var/run/docker.sock | ||
| codeclimate/patrick pull || true | ||
| - make image |
There was a problem hiding this comment.
These make commands seem valid but you haven't written them yet
Language can be autodetected and the specified language version was just wrong. It was inheriting a version previously set for `apex`, not `java`.
filipesperandio
commented
Sep 8, 2017
| --env CIRCLE_TOKEN | ||
| --env GCR_JSON_KEY | ||
| --volume /var/run/docker.sock:/var/run/docker.sock | ||
| codeclimate/patrick pull || true |
There was a problem hiding this comment.
@gordondiggs Will was suggesting skip patrick and pull/push directly to docker hub. I will do so in a new PR.
gdiggs
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.