Allow java version to be specified #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesperandio
changed the title
codeclimate-hermes
requested review from
maxjacobson
and removed request for
codeclimate-hermes
filipesperandio
force-pushed
the
fe/generic-properties
branch
from
ce06ce7 to
35c4a69
Compare
dblandin
approved these changes
Oct 17, 2017
maxjacobson
reviewed
Oct 17, 2017
| @@ -66,4 +66,4 @@ public void capture_exceptions_and_log_to_stderr() throws Exception { | |||
| assertThat(system.exitCode).isEqualTo(1); | |||
| assertThat(stderr.toString()).contains("Can't find project home. System property not set: project.home"); | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
it would be nice not to make changes like this if it's not needed
| @Test | ||
| public void specify_java_source_version_through_config() throws Exception { | ||
| Shell.Process process = Shell.execute("build/codeclimate-sonar fixtures/java_source_version fixtures/java_source_version/config.json"); | ||
| assertThat(process.stderr).contains("Configured Java source version (sonar.java.source): 6"); |
There was a problem hiding this comment.
why is this 6 when the file specifies 1.6?
There was a problem hiding this comment.
This is java stupidity. Not sure if it was Sun/Oracle or the community, but after java 1.5 the versions became ambiguous: 1.6 -> 6; 1.7 -> 7...
Sonar handles both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to easily pass Java properties through the config.yml:
Related to #10