Add support for excoveralls json format #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeclimate-hermes
requested review from
toddmazierski
and removed request for
codeclimate-hermes
ale7714
changed the title
* Coverage tool https://github.com/parroty/excoveralls using coveralls.json format
toddmazierski
approved these changes
Dec 19, 2017
| COPY . . | ||
| RUN go install -v | ||
|
|
||
| RUN git clone https://github.com/ale7714/excoveralls.git |
There was a problem hiding this comment.
Should this be hosted on the codeclimate account?
There was a problem hiding this comment.
gonna go with codecliamte-testing, since we're only using this for testing. Not really any development.
| r.Equal(lc.Covered, 14) | ||
| r.Equal(lc.Missed, 1) | ||
| r.Equal(lc.Total, 15) | ||
| } |
There was a problem hiding this comment.
Do you think it'd be worth adding coverage for the could not find any files, could not open coverage file states, too?
ale7714
force-pushed
the
ap-add-support-for-excoveralls
branch
from
a106063 to
8b0eed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coveralls.json format
Related to parroty/excoveralls#119