Ignore invalid lines in cobertuna formatter #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the test reporter from crashing when an invalid line number is detected in the cobertuna.xml coverage file. While this does not address the actual issue causing invalid line numbers, it does allow the test reporter to ignore the invalid lines. Related: SlatherOrg/slather#387 Addresses: #320
ale7714
approved these changes
May 14, 2018
chrishulton
pushed a commit
that referenced
this pull request
May 15, 2018
* [FIX] Update `Cobertura` formatter to ignore invalid line numbers in a `cobertura.xml` file #335
Merged
chrishulton
pushed a commit
that referenced
this pull request
May 16, 2018
* [FIX] Update `Cobertura` formatter to ignore invalid line numbers in a `cobertura.xml` file #335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the test reporter from crashing when an invalid line
number is detected in the cobertuna.xml coverage file.
While this does not address the actual issue causing invalid line
numbers, it does allow the test reporter to ignore the invalid lines.
Related: SlatherOrg/slather#387
Addresses: #320