Fix gcov formatter #338
Merged
Fix gcov formatter #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds getSourFileName. Formatter will parse from coverage file the source file name, use it to create the SourceFile and then, add it to the Report. * Updates specs and fixtures so we ensure that we're returning actual source file names and not coverage file names. Addresses #328
codeclimate-hermes
requested review from
wilson
and removed request for
codeclimate-hermes
chrishulton
approved these changes
May 21, 2018
formatters/gcov/gcov.go
Outdated
| @@ -116,3 +123,27 @@ func parseSourceFile(fileName string, gitHead *object.Commit) (formatters.Source | |||
|
|
|||
| return sf, nil | |||
| } | |||
|
|
|||
| func getSourFileName(coverageFileName string) (string, error) { | |||
There was a problem hiding this comment.
just a small typo here: getSourFileName -> getSourceFileName
Merged
ale7714
pushed a commit
that referenced
this pull request
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds getSourFileName. Formatter will parse from coverage file
the source file name, use it to create the SourceFile and
then, add it to the Report.
Updates specs and fixtures so we ensure that we're returning
actual source file names and not coverage file names.
Addresses #328
Successful report uploaded here using
make test-gcov.