[CE-919] AWS CodeBuild detected, but fail to upload

[blakemorgan]

When I run npm test && codecov (after the codecov package has been installed globally), I get the following output:

  _____          _   
 / ____|        | |   
| |     ___   __| | ___  ___ _____   __   
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /   
| |___| (_) | (_| |  __/ (_| (_) \ V /   
 \_____\___/ \__,_|\___|\___\___/ \_/   
                                v3.6.1 
==> Detecting CI Provider 
    AWS CodeBuild Detected 
==> Configuration:  
    Endpoint: https://codecov.io 
{ commit: 'c6df5d3b21ab1f6dc345b5e8a382b9895fc42ba8', 
  branch: 'dev', 
  package: 'node-v3.6.1' } 
==> Building file structure 
==> Generating gcov reports (skip via --disable=gcov) 
    $ find /codebuild/output/src294305816/src/github.com/byu-oit/campus-map -type f -name '*.gcno'  -exec gcov  {} + 
==> Scanning for reports 
    + /codebuild/output/src294305816/src/github.com/byu-oit/campus-map/coverage/lcov.info 
    + /codebuild/output/src294305816/src/github.com/byu-oit/campus-map/coverage/clover.xml 
==> Uploading reports 
    HTTP 400 
service must be ci-provider 

As you can see, Codecov detects AWS CodeBuild, but for some reason, when it tries to upload the report, a 400 error is returned with the message service must be a ci-provider.

[eddiemoore]

Hi @blakemorgan , Can you submit a ticket to support@codecov.io

[blakemorgan]

I already did.

[trivikr]

Any update on this?
We're also blocked because of this issue in aws/aws-sdk-js-v3#392

[trivikr]

The code which prints "Uploading reports":

codecov-node/lib/codecov.js

Line 520 in d81c4f4

console.log('==> Uploading reports')

The code which prints success/error:

codecov-node/lib/codecov.js

Lines 161 to 172 in d81c4f4

	function(err, response) {
	if (err || response.statusCode !== 200) {
	console.log(' ' + (err || response.body))
	return response
	? on_failure(response.statusCode, response.body)
	: on_failure(err.code, err.message)
	} else {
	console.log(' Success!')
	console.log(' View report at: ' + response.body)
	return on_success(response.body)
	}
	}

The error shown in CodeBuild (from aws/aws-sdk-js-v3#366):

[Container] 2019/10/21 20:23:41 Phase complete: BUILD State: SUCCEEDED
[Container] 2019/10/21 20:23:41 Phase context status code:  Message: 
[Container] 2019/10/21 20:23:41 Entering phase POST_BUILD
[Container] 2019/10/21 20:23:41 Running command ./node_modules/.bin/codecov -f coverage/*.json
  _____          _  
 / ____|        | |  
| |     ___   __| | ___  ___ _____   __  
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /  
| |___| (_) | (_| |  __/ (_| (_) \ V /  
 \_____\___/ \__,_|\___|\___\___/ \_/  
                                v3.6.1
==> Detecting CI Provider
    AWS CodeBuild Detected
==> Configuration: 
    Endpoint: https://codecov.io
{ commit: '6594db294267328124117dc0aac6da3a7266e263',
  branch: 'dependabot/npm_and_yarn/commitlint/config-conventional-8.2.0',
  package: 'node-v3.6.1' }
==> Building file structure
==> Generating gcov reports (skip via --disable=gcov)
    $ find /codebuild/output/src367505339/src/github.com/aws/aws-sdk-js-v3 -type f -name '*.gcno'  -exec gcov  {} +
==> Targeting specific file
    + /codebuild/output/src367505339/src/github.com/aws/aws-sdk-js-v3/coverage/coverage-final.json
==> Uploading reports
    HTTP 400
service must be ci-provider

The success message shown with TravisCI (from aws/aws-sdk-js-v3#416):

$ ./node_modules/.bin/codecov -f coverage/*.json
  _____          _  
 / ____|        | |  
| |     ___   __| | ___  ___ _____   __  
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /  
| |___| (_) | (_| |  __/ (_| (_) \ V /  
 \_____\___/ \__,_|\___|\___\___/ \_/  
                                v3.5.0
==> Detecting CI Provider
    Travis CI Detected
==> Configuration: 
    Endpoint: https://codecov.io
{ commit: '1034e7ec74611df36c53facb367e1d8cab279324',
  branch: 'AllanFly120-patch-4',
  package: 'node-v3.5.0' }
==> Building file structure
==> Generating gcov reports (skip via --disable=gcov)
    $ find /home/travis/build/aws/aws-sdk-js-v3 -type f -name '*.gcno'  -exec gcov  {} +
==> Targeting specific file
    + /home/travis/build/aws/aws-sdk-js-v3/coverage/coverage-final.json
==> Uploading reports
    Success!
    View report at: https://codecov.io/github/aws/aws-sdk-js-v3/commit/1034e7ec74611df36c53facb367e1d8cab279324
Done. Your build exited with 0.

[trivikr]

This issue could be related to naming of service?

• Semaphore CI also faced the same issue as discussed in Add retro-compatibility for Semaphore 1.x and maintain support for 2.x #145 (comment)
• It was fixed in Fix semaphore service #146

[trivikr]

Checked the naming of CodeBuild:

• It's "codebuild" in lib/services/codebuild.js
  

  codecov-node/lib/services/codebuild.js

  Line 9 in 9bde072

  service: 'codebuild',

• Search results for other occurrences of "codebuild" in this repository https://github.com/codecov/codecov-node/search?q=codebuild&type=Code

[trivikr]

As per comment codecov/codecov-bash#99 (comment), the issue is likely to be on the server side

[eddiemoore]

Yeah it's a server side thing. I'm only a contributor and don't actually work at Codecov. However I will ask the team if they can do something about it.

[trivikr]

Thank you @eddiemoore for the response.
I've created support ticket with CodeCov at https://codecov.freshdesk.com/support/tickets/2303

[drazisil]

Thanks for raising this, @trivikr

Yes, adding any new CI provider service to an uploader requires that service name to be added to the upload endpoint to ensure Codecov can handle it correctly. It looks like that was missed here as we didn't know about this change.

I've raised a PR on the backend, hope to have it merged and deployed soon.

[trivikr]

Thank you @drazisil for raising PR in the backend.
Is there a place where I can follow up the merge and deployment updates?

[trivikr]

Issue created with codecov-bash at codecov/codecov-bash#216