-
Notifications
You must be signed in to change notification settings - Fork 34.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Build Your Own Kafka #1385
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request updates the documentation by adding a new subsection under the "Tutorials" heading in the README. This new subsection, titled Build your own Distributed Systems, includes a tutorial entry that links to a Java guide for building a Kafka-like system from scratch. The update provides additional resources for users interested in distributed systems without impacting any application code. Changes
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
41-41
: Adjust Heading Level for Consistency
The heading "#### Build your ownDistributed Systems
" is four levels deep, which is too steep given that the parent heading "## Tutorials" is at level two. To ensure proper hierarchical progression, change this heading to level three (i.e., use "###").-#### Build your own `Distributed Systems` +### Build your own `Distributed Systems`🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
41-41: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4(MD001, heading-increment)
42-42
: Standardize Emphasis Style
Markdownlint expects the use of asterisks for emphasis instead of underscores. Please update the italic formatting in the tutorial entry by replacing underscores with asterisks.-* [**Java**: _Building Your Own Kafka-like System From Scratch: A Step-by-Step Guide_](https://github.com/buildthingsuseful/build-your-own-kafka) +* [**Java**: *Building Your Own Kafka-like System From Scratch: A Step-by-Step Guide*](https://github.com/buildthingsuseful/build-your-own-kafka)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
42-42: Emphasis style
Expected: asterisk; Actual: underscore(MD049, emphasis-style)
42-42: Emphasis style
Expected: asterisk; Actual: underscore(MD049, emphasis-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
41-41: Heading levels should only increment by one level at a time
Expected: h3; Actual: h4
(MD001, heading-increment)
42-42: Emphasis style
Expected: asterisk; Actual: underscore
(MD049, emphasis-style)
42-42: Emphasis style
Expected: asterisk; Actual: underscore
(MD049, emphasis-style)
Building Your Own Kafka-like System From Scratch: A Step-by-Step Guide
Summary by CodeRabbit