-
Notifications
You must be signed in to change notification settings - Fork 34.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README. to add sync engine blog post #1393
base: master
Are you sure you want to change the base?
Update README. to add sync engine blog post #1393
Conversation
WalkthroughThe pull request adds a new entry to the "Node.js" section of the README.md file, specifically under the tutorials list. The entry titled "Build a Synchronization Engine with Node.js and Y.js" includes a link to the corresponding tutorial, thereby enhancing the resources available for users interested in learning about synchronization engines with Node.js. Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
452-452
: Entry Title Inconsistency and Markdown Formatting IssueThe new Node.js entry is added with the text:
* [**Node.js**: _Build a Synchronization Engine with Node.js_and Y.js](https://greenvitriol.com/posts/sync-engine-for-everyone)
There are two points to address:
- Markdown Formatting: The underscore in “Node.js_and Y.js” may cause unintended italicization. It likely should be a space (e.g., "Node.js and Y.js") to ensure proper rendering.
- Title Consistency: The PR objectives mention the blog post is titled “Sync Engine for Everyone,” while the entry text reads “Build a Synchronization Engine with Node.js and Y.js.” Please verify if the entry title should exactly match the blog post title or if the current phrasing is intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
452-452
: New Sync Engine Entry AddedThe new entry for the Node.js section is correctly added and points to the intended URL. Please verify that the title now aligns with your messaging—the blog post is titled “Sync Engine for Everyone,” while the entry currently reads “Build a Synchronization Engine with Node.js and Y.js.” If consistency is desired, consider updating the title accordingly.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
452-452: Emphasis style
Expected: asterisk; Actual: underscore(MD049, emphasis-style)
452-452: Emphasis style
Expected: asterisk; Actual: underscore(MD049, emphasis-style)
452-452
: Markdown Emphasis Style RecommendationThe static analysis tool flagged an emphasis style issue on this line (MD049). Currently, the entry uses underscores for emphasis (e.g., Build a Synchronization Engine with Node.js and Y.js). To align with the markdown style guidelines that prefer asterisk-based emphasis, please consider changing the underscores to asterisks.
Below is a suggested diff:
-* [**Node.js**: _Build a Synchronization Engine with Node.js and Y.js_](https://greenvitriol.com/posts/sync-engine-for-everyone) +* [**Node.js**: *Build a Synchronization Engine with Node.js and Y.js*](https://greenvitriol.com/posts/sync-engine-for-everyone)🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
452-452: Emphasis style
Expected: asterisk; Actual: underscore(MD049, emphasis-style)
452-452: Emphasis style
Expected: asterisk; Actual: underscore(MD049, emphasis-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
452-452: Emphasis style
Expected: asterisk; Actual: underscore
(MD049, emphasis-style)
452-452: Emphasis style
Expected: asterisk; Actual: underscore
(MD049, emphasis-style)
Add this article: https://greenvitriol.com/posts/sync-engine-for-everyone
Summary by CodeRabbit