Skip to content

Bump org.codehaus.plexus:plexus from 18 to 19 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plexus-java/src/site/markdown/locationmanager.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This jar is a multi release jar (aka MRJAR), because it contains 2 implementatio

When extracting the the automatic module name based the of the file, it is a little bit more complex. The result must be precise, so the only way to solve this is by calling Java 9 code, either from the runtime or by calling Java 9 explicitly when provided via `ResolvePathsRequest.setJdkHome`.

## Request
# Request

The `LocationManager.resolvePaths()` only has one argument, `ResolvePathsRequest`. If there is more data required, the request will be extended so the method signature of `resolvePaths` will stay the same.

Expand All @@ -30,7 +30,7 @@ Additional methods are:

- `setMainModuleDescriptor`, which can either be a `module-info.java` or `module-info.class`

## Phase 1: Collect
# Phase 1: Collect

If there's a `mainModuleDescriptor`, extract a `JavaModuleDescriptor` of it. This might cause a `IOException` to be thrown.

Expand All @@ -50,13 +50,13 @@ The result are a couple of Maps:

* module name to `JavaModuleDescriptor`

## Phase 2: Resolve
# Phase 2: Resolve

If there's a `mainModuleDescriptor`, collect all its direct and indirect requirements.
This contains recursive code and ensures that required modules are only evaluated once.
All these pathElements must be placed on the modulepath, all other pathElements will be marked for the classPath.

## Result
# Result
All results will be stored in a `ResolvePathsResult`.

- `getClasspathElements()`, ordered collection of all pathElements that don't belong to the modulepath
Expand Down
9 changes: 4 additions & 5 deletions plexus-java/src/site/markdown/usage.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

## LocationManager.resolvePaths
# LocationManager.resolvePaths

In order to use this class you must setup a `ResolvePathsRequest`, which requires a list of all the jars and output directories and the main module descriptor.

Expand All @@ -25,13 +25,12 @@ The `ResolvePathsResult` contains:

* pathExceptions: pathElements with their exception while trying to resolve it. Only pathElements with an exception are listed.

## JavaVersion
# JavaVersion

This is a String based, lazy-parsing implementation of a Java Version which can be used to compare versions. It's goal is to support to support the following patterns:

* [Java SE Naming and Versions](http://www.oracle.com/technetwork/java/javase/namechange-140185.html)
* [JEP 223: New Version-String Scheme](http://openjdk.java.net/jeps/223)
* [JEP 322: Time-Based Release Versioning](http://openjdk.java.net/jeps/322)
* [JEP 223: New Version-String Scheme](https://openjdk.java.net/jeps/223)
* [JEP 322: Time-Based Release Versioning](https://openjdk.java.net/jeps/322)

Additional features:

Expand Down
9 changes: 4 additions & 5 deletions plexus-java/src/site/site.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,18 @@ specific language governing permissions and limitations
under the License.
-->

<project xmlns="http://maven.apache.org/DECORATION/1.8.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/DECORATION/1.8.0 https://maven.apache.org/xsd/decoration-1.8.0.xsd">
<site xmlns="http://maven.apache.org/SITE/2.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/SITE/2.0.0 https://maven.apache.org/xsd/site-2.0.0.xsd">
<body>
<menu name="Overview">
<item name="Introduction" href="index.html"/>
<item name="Usage" href="usage.html"/>
<item name="LocationManager" href="locationmanager.html"/>
<item name="JavaDocs" href="apidocs/index.html"/>
<item name="Source Xref" href="xref/index.html"/>
<!--item name="FAQ" href="faq.html"/-->
</menu>

<menu ref="parent"/>
<menu ref="reports"/>
</body>
</project>
</site>
8 changes: 6 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus</artifactId>
<version>18</version>
<version>19</version>
</parent>

<artifactId>plexus-languages</artifactId>
Expand All @@ -27,8 +27,12 @@
</scm>
<issueManagement>
<system>github</system>
<url>http://github.com/codehaus-plexus/plexus-languages/issues</url>
<url>https://github.com/codehaus-plexus/plexus-languages/issues</url>
</issueManagement>
<ciManagement>
<system>GitHub</system>
<url>https://github.com/codehaus-plexus/plexus-languages/actions</url>
</ciManagement>
<distributionManagement>
<site>
<id>github:gh-pages</id>
Expand Down
30 changes: 0 additions & 30 deletions src/site/site.xml

This file was deleted.