Skip to content

Group runInSeparateProcess and preserveGlobalState #6788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2022

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Oct 30, 2022

Description
Closes #6783
The relevant php-cs-fixer rule will be adjusted in coding-standard (CodeIgniter/coding-standard@644b3ed)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan added a commit to CodeIgniter/coding-standard that referenced this pull request Oct 30, 2022
@paulbalandan paulbalandan merged commit f355282 into codeigniter4:develop Oct 30, 2022
@paulbalandan paulbalandan deleted the preserve-global-state branch October 30, 2022 13:20
@ddevsr
Copy link
Collaborator

ddevsr commented Oct 30, 2022

@paulbalandan
Copy link
Member Author

That must have been added in 4.3. The PR targeted develop.

@paulbalandan
Copy link
Member Author

Follow-up PR underway.

@paulbalandan paulbalandan mentioned this pull request Oct 30, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev: @runInSeparateProcess and @preserveGlobalState should be grouped
4 participants