-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: Filter Arguments with $filters in Config\Filters #7159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If both the Route filter and Config filter are applied, should the Route filter's arguments take precedence? → The route filter's arguments take precedence. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Long-requested feature.
Co-authored-by: MGatner <[email protected]>
5433406
to
5c46faa
Compare
481d5a3
to
472562d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good.
I like this PR 💯 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
$filters
inConfig\Filters
Checklist: