perf: add Services::get()

[kenjis]

Description

• add Services::get() method to get the shared instance fast.
• service() uses Services::get()

 Test 			Time 	Memory
services::timer() 	0.1337 	0 Bytes
services::get('timer') 	0.0406 	0 Bytes
service('timer') 	0.0528 	0 Bytes

<?php

namespace App\Controllers;

use CodeIgniter\Debug\Iterator;
use Config\Services;

class Home extends BaseController
{
    public function index(): string
    {
        $iterator = new Iterator();

        Services::timer();

        $iterator->add('Services::timer()', static function () {
            $timer = Services::timer();
        });

        $iterator->add("Services::get('timer')", static function () {
            $timer = Services::get('timer');
        });

        $iterator->add("service('timer')", static function () {
            $timer = service('timer');
        });

        return $iterator->run(300000);
    }
}

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

Applicable review until override().

mixed should be limited to object, as the static array prop $instances accepts object as value. I don't think we need to accept anything to be set. Accepting mixed may lead to future misuses.

[kenjis]

Changed to ?object.

[paulbalandan]

See comment before.

[paulbalandan]

Suggested change

	throw new InvalidArgumentException('The Entry for "' . $key . '" is already set.');
	throw new InvalidArgumentException('The entry for "' . $key . '" is already set.');

[kenjis]

Fixed.

[paulbalandan]

See comment above

[lonnieezell]

The more I think about this the more confused I am about the performance issue we're seeing. All methods are static and should be called before __callStatic if the case matches, shouldn't it? So that should be higher performance than either get() or __callStatic.

[kenjis]

The current Services is not that simple.
__callStatic is called in most cases.
Because Config\Services extends BaseService.

CodeIgniter4/app/Config/Services.php

Line 20 in fd28a3f

class Services extends BaseService

and BaseService has only autoloader and locator.

$ grep function system/Config/BaseService.php 
    public static function get(string $key): ?object
    public static function set(string $key, object $value): void
    public static function override(string $key, object $value): void
    protected static function getSharedInstance(string $key, ...$params)
    public static function autoloader(bool $getShared = true)
    public static function locator(bool $getShared = true)
    public static function __callStatic(string $name, array $arguments)
    public static function serviceExists(string $name): ?string
    public static function reset(bool $initAutoloader = true)
    public static function resetSingle(string $name)
    public static function injectMock(string $name, $mock)
    protected static function buildServicesCache(): void

[lonnieezell]

Yeah, I guess the only ones that would hit directly would be in app/Config/Services. That's too bad.

[neznaika0]

How do I work with the magic of services? The analyzer swears at the returned type. It looks sad.

// some code
$this->request = service('request');

Errors:

3) tests/system/Honeypot/HoneypotTest.php:37

    ---------- begin diff ----------
@@ @@
     /**
      * @var CLIRequest|IncomingRequest
      */
-    private $request;
+    private ?object $request = null;

     private Response $response;
    ----------- end diff -----------

Applied rules:
 * TypedPropertyFromAssignsRector