Restore "deleted" user

[MarcPinnell]

I am trying to restore or undelete a user that was deleted using the softdelete function. The "deleted_at" column has a date in it (as it should). I should be able to restore the user by replacing the date with NULL, but I can't get it to save. I have added additional columns to update as a test during the update, and they update properly so I know I am updating the record, I just can't seem to remove the date in the "deleted_at" column. Any suggestions?

$user = $this->userModel->withDeleted()->findById($id);
$user->fill(['deleted_at' => null]);
$this->userModel->save($user);

[datamweb]

I don't see any problem, column deleted_at is updated without problem and you can update it with null.
Make sure the following is set.

protected $allowedFields  = [
...
  'deleted_at',
];

code:

$users = model('UserModel');
$user = $users->withDeleted()->findById(11);
$user->fill([
        'deleted_at' => null
        ]);
return $users->save($user);

[MarcPinnell]

Except it doesn't. :(
Just to verify there wasn't an issue with the table, I tried running a query directly against the table and it worked fine:

UPDATE users SET deleted_at = NULL WHERE id = 21

I also checked the value of $user before submission and verified that it contained a NULL value for deleted_at.

Very frustrating. Seems like it is dropping the deleted_at from the query or something

[datamweb]

I was curious what database you are using?

[MarcPinnell]

MariaDB 10.3.35

[MarcPinnell]

Well, there is almost always multiple ways to accomplish something, right?

$sql = 'UPDATE users SET deleted_at = NULL WHERE id = '.$id;
$records = $this->userModel->query($sql);

Solved. Working fine now.

[MGatner]

You probably need to call withDeleted() again in your save() operation.

[datamweb]

Inheritance is different from overwriting, when you put

    protected $allowedFields  = [
        'username',
        'status',
        'status_message',
        'active',
        'last_active',
        'deleted_at',
    ];

in new Model, it actually overwrites it.
I suggest you see Object-Oriented PHP by Jill Gundersen

[paulbalandan]

The Shield team might want to consider adding a protected constant UserModel::DEFAULT_ALLOWED_FIELDS so that if anyone wants to add on top of the default allowed fields they can do so by array unpacking the defaults plus their own.

see https://3v4l.org/I84pS

[kenjis]

Adding UserModel::DEFAULT_ALLOWED_FIELDS might be better.

[MGatner]

I typically just add to the property in a model's initialize() function: https://github.com/tattersoftware/bluesmith/blob/develop/app/Models/UserModel.php

That way if the upstream property changes I'm not missing out.

[MarcPinnell]

MGatner's solution is probably best until / if the core is changed as suggested by paulbalandan and kenjis... Thanks all

[MarcPinnell]

In case someone finds this later, here is the final solution:

In the controller:

	public function make_active($id)
	{
		$user = $this->userModel->withDeleted()->findById($id);
		$user->fill(['deleted_at' => null]);
		$this->userModel->save($user);

		return redirect()	->to("/admin/users/main")
							 ->with('info', 'User successfully activated.');
	}

The custom model:

namespace App\Models;

use CodeIgniter\Shield\Models\UserModel;

class Userp42Model extends UserModel
{
	protected function initialize()
	{
		$newAllowedFields  = [
			'fname','lname','user_uid',
			'phone_home','phone_cell','phone_ext','phone_desk',
			'is_superadmin',
			'profile_image',
			'calview','homepage',
		];
		// Merge properties with parent
		$this->allowedFields   = array_merge($this->allowedFields, $newAllowedFields);
	}