start invoker at a port specified from cli #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| command2 = config.processes[1] | ||
|
|
||
| expect(command2.port).to eq(9002) | ||
| expect(command2.cmd).to match(/9002/) | ||
| expect(command2.port).to eq(9000) |
There was a problem hiding this comment.
should this be port 9000 for all servers?
initialize takes a port form cli and decrements it by 1 and sets the instance variable @PORT. This port value is used as the environment variable $PORT inside invoker.ini. When method pick_port gets fired it increments the value of port by 1, subsequently when pick_port again gets fired, for another command, it will again increment port value by 1, that way generating different ports for different commands.
iffyuva
added a commit
that referenced
this pull request
Sep 21, 2015
start invoker at a port specified from cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently invoker accepts a port from cli, increments it by 1, and then starts the process at that port.
This deteres a user from running invoker on a port of her choice.