Skip to content

[Bug]: dangling links in 4.3.0 release #5157

Closed
@skumagai

Description

@skumagai

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

It's about the release file for macOS.

Steps to Reproduce

  1. Download standalone 4.3.0 for macOS (code-server-4.3.0-macos-amd64.tar.gz) from github
  2. Untar the file
  3. find code-server-4.3.0-macos-amd64 -xtype l

Expected

No output/dangling link

Actual

code-server-4.3.0-macos-amd64/lib/vscode/extensions/node_modules/.bin/tsc
code-server-4.3.0-macos-amd64/lib/vscode/extensions/node_modules/.bin/tsserver

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code?

  • I cannot reproduce this in VS Code.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

First, I'm not sure if this is a bug. If not, feel free to close this issue.

I was working to make 4.3.0 available as a conda package in conda-forge/code-server-feedstock#62, and I noticed a build was failing on macOS due to dangling links (see: CI pipeline.

Manually unpacking 4.3.0 release for macOS confirms that lib/vscode/extensions/node_modules/.bin/{tsc,tsserver} are pointing to nonexistent ../typescript/bin/{tsc,tsserver} (../typescript/bin directory doesn't exist).

Since I don't code in Javascript and Typescript, I can't asses if this has any impact or not. Nevertheless, I thought it might be good to let you know about it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions