-
Notifications
You must be signed in to change notification settings - Fork 6k
fix(socket): use xdgBasedir.runtime instead of tmp #3304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
adc4463
a57ee69
2a657ab
d7f1415
46fe77d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,147 @@ | ||
describe("getEnvPaths", () => { | ||
describe("on darwin", () => { | ||
let ORIGINAL_PLATFORM = "" | ||
|
||
beforeAll(() => { | ||
ORIGINAL_PLATFORM = process.platform | ||
|
||
Object.defineProperty(process, "platform", { | ||
value: "darwin", | ||
}) | ||
}) | ||
|
||
beforeEach(() => { | ||
jest.resetModules() | ||
jest.mock("env-paths", () => { | ||
return () => ({ | ||
data: "/home/envPath/.local/share", | ||
config: "/home/envPath/.config", | ||
temp: "/tmp/envPath/runtime", | ||
Comment on lines
+16
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For whatever reason, when I extract this object into a variable and pass in to the mock, it doesn't work 🤷♂️ |
||
}) | ||
}) | ||
}) | ||
|
||
afterAll(() => { | ||
// Restore old platform | ||
|
||
Object.defineProperty(process, "platform", { | ||
value: ORIGINAL_PLATFORM, | ||
}) | ||
}) | ||
|
||
it("should return the env paths using xdgBasedir", () => { | ||
jest.mock("xdg-basedir", () => ({ | ||
data: "/home/usr/.local/share", | ||
config: "/home/usr/.config", | ||
runtime: "/tmp/runtime", | ||
})) | ||
const getEnvPaths = require("../../../src/node/util").getEnvPaths | ||
Comment on lines
+33
to
+38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have to do this because of: jestjs/jest#2582 (comment) |
||
const envPaths = getEnvPaths() | ||
|
||
expect(envPaths.data).toEqual("/home/usr/.local/share/code-server") | ||
expect(envPaths.config).toEqual("/home/usr/.config/code-server") | ||
expect(envPaths.runtime).toEqual("/tmp/runtime/code-server") | ||
}) | ||
|
||
it("should return the env paths using envPaths when xdgBasedir is undefined", () => { | ||
jest.mock("xdg-basedir", () => ({})) | ||
const getEnvPaths = require("../../../src/node/util").getEnvPaths | ||
const envPaths = getEnvPaths() | ||
|
||
expect(envPaths.data).toEqual("/home/envPath/.local/share") | ||
expect(envPaths.config).toEqual("/home/envPath/.config") | ||
expect(envPaths.runtime).toEqual("/tmp/envPath/runtime") | ||
}) | ||
}) | ||
describe("on win32", () => { | ||
let ORIGINAL_PLATFORM = "" | ||
|
||
beforeAll(() => { | ||
ORIGINAL_PLATFORM = process.platform | ||
|
||
Object.defineProperty(process, "platform", { | ||
value: "win32", | ||
}) | ||
}) | ||
|
||
beforeEach(() => { | ||
jest.resetModules() | ||
jest.mock("env-paths", () => { | ||
return () => ({ | ||
data: "/windows/envPath/.local/share", | ||
config: "/windows/envPath/.config", | ||
temp: "/tmp/envPath/runtime", | ||
}) | ||
}) | ||
}) | ||
|
||
afterAll(() => { | ||
// Restore old platform | ||
|
||
Object.defineProperty(process, "platform", { | ||
value: ORIGINAL_PLATFORM, | ||
}) | ||
}) | ||
|
||
it("should return the env paths using envPaths", () => { | ||
const getEnvPaths = require("../../../src/node/util").getEnvPaths | ||
const envPaths = getEnvPaths() | ||
|
||
expect(envPaths.data).toEqual("/windows/envPath/.local/share") | ||
expect(envPaths.config).toEqual("/windows/envPath/.config") | ||
expect(envPaths.runtime).toEqual("/tmp/envPath/runtime") | ||
}) | ||
}) | ||
describe("on other platforms", () => { | ||
let ORIGINAL_PLATFORM = "" | ||
|
||
beforeAll(() => { | ||
ORIGINAL_PLATFORM = process.platform | ||
|
||
Object.defineProperty(process, "platform", { | ||
value: "linux", | ||
}) | ||
}) | ||
|
||
beforeEach(() => { | ||
jest.resetModules() | ||
jest.mock("env-paths", () => { | ||
return () => ({ | ||
data: "/linux/envPath/.local/share", | ||
config: "/linux/envPath/.config", | ||
temp: "/tmp/envPath/runtime", | ||
}) | ||
}) | ||
}) | ||
|
||
afterAll(() => { | ||
// Restore old platform | ||
|
||
Object.defineProperty(process, "platform", { | ||
value: ORIGINAL_PLATFORM, | ||
}) | ||
}) | ||
|
||
it("should return the runtime using xdgBasedir if it exists", () => { | ||
jest.mock("xdg-basedir", () => ({ | ||
runtime: "/tmp/runtime", | ||
})) | ||
const getEnvPaths = require("../../../src/node/util").getEnvPaths | ||
const envPaths = getEnvPaths() | ||
|
||
expect(envPaths.data).toEqual("/linux/envPath/.local/share") | ||
expect(envPaths.config).toEqual("/linux/envPath/.config") | ||
expect(envPaths.runtime).toEqual("/tmp/runtime/code-server") | ||
}) | ||
|
||
it("should return the env paths using envPaths when xdgBasedir is undefined", () => { | ||
jest.mock("xdg-basedir", () => ({})) | ||
const getEnvPaths = require("../../../src/node/util").getEnvPaths | ||
const envPaths = getEnvPaths() | ||
|
||
expect(envPaths.data).toEqual("/linux/envPath/.local/share") | ||
expect(envPaths.config).toEqual("/linux/envPath/.config") | ||
expect(envPaths.runtime).toEqual("/tmp/envPath/runtime") | ||
}) | ||
}) | ||
}) |
Uh oh!
There was an error while loading. Please reload this page.