chore(deps): update dependency @types/node to v16 #5170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
✨ code-server docs for PR #5170 is ready! It will be updated on every commit.
|
renovate
bot
force-pushed
the
renovate/node-16.x
branch
5 times, most recently
from
9c550a2 to
39583cb
Compare
|
This will require some manual work to make sure everything is working. |
renovate
bot
force-pushed
the
renovate/node-16.x
branch
7 times, most recently
from
fbbd77e to
fee0c3a
Compare
renovate
bot
force-pushed
the
renovate/node-16.x
branch
2 times, most recently
from
2f7fa6a to
6fb4c9d
Compare
renovate
bot
force-pushed
the
renovate/node-16.x
branch
3 times, most recently
from
a1635d5 to
7bc2d13
Compare
renovate
bot
force-pushed
the
renovate/node-16.x
branch
from
7bc2d13 to
9244392
Compare
renovate
bot
force-pushed
the
renovate/node-16.x
branch
from
9244392 to
b65aabc
Compare
Fixes a number of conflicts it has with Node 16.
code-asher
force-pushed
the
renovate/node-16.x
branch
from
8a09918 to
0e56c34
Compare
It seems req was `any` before so now we have to handle the types. Also it seems the socket is of type `stream.Duplex`, not `net.Socket`. The ws types had to be updated to support the new type. Unfortunately Code still uses the old type so cast for now. In the web socket router just use a cast for the extra properties we add. We could add the types to the Express namespace but I am not sure we really want these commonly accessible so keep with the casts for now. Likely we should use Express's `locals` or something instead.
code-asher
force-pushed
the
renovate/node-16.x
branch
from
0e56c34 to
9883a87
Compare
Not sure why it only just now started complaining though.
Codecov Report
@@ Coverage Diff @@
## main #5170 +/- ##
==========================================
+ Coverage 72.42% 72.44% +0.01%
==========================================
Files 30 30
Lines 1672 1673 +1
Branches 366 366
==========================================
+ Hits 1211 1212 +1
Misses 398 398
Partials 63 63
Continue to review full report at Codecov.
|
code-asher
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^14.17.1->^16.0.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.