chore: handle waking from device sleep #50
Merged
+41
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanndickson
force-pushed
the
ethan/handle-wake
branch
from
e77ea5a to
5710fdd
Compare
ethanndickson
changed the title
ethanndickson
force-pushed
the
ethan/handle-wake
branch
from
5710fdd to
ca53d20
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ethanndickson
force-pushed
the
ethan/handle-wake
branch
from
ca53d20 to
8463ffe
Compare
ethanndickson
changed the title
ethanndickson
force-pushed
the
ethan/handle-wake
branch
4 times, most recently
from
f66f2d8 to
ac93c9c
Compare
ethanndickson
force-pushed
the
ethan/handle-wake
branch
from
d7597fc to
e98f091
Compare
ethanndickson
force-pushed
the
ethan/handle-wake
branch
from
e98f091 to
d4961f6
Compare
ThomasK33
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on coder/coder#16598.
Reverts #43.
Whilst everything seems to recover okay tailnet wise when waking from sleep currently, the tunnel will still miss workspace/peer updates during the sleep, causing the workspace state in the UI to be out of sync with reality.
To handle this, we'll teardown the tunnel on sleep, and bring it back up on wake.
Fixing the issue in
coder/coderalso revealed that the error encountered when toggling the VPN on and off quickly was another symptom, and so this change reverts the code that prevents toggling the VPN on and off quickly, as it now works flawlessly.