Skip to content

feat: implement repo-mode #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2024
Merged

feat: implement repo-mode #290

merged 4 commits into from
Aug 1, 2024

Conversation

mafredri
Copy link
Member

Fixes #218

@mafredri mafredri force-pushed the mafredri/repo-mode branch 3 times, most recently from 0acb5f6 to 5d4e5ca Compare July 30, 2024 18:04
@mafredri mafredri force-pushed the mafredri/repo-mode branch from 5d4e5ca to 54a037e Compare August 1, 2024 13:23
@mafredri mafredri marked this pull request as ready for review August 1, 2024 13:29
@mafredri mafredri requested a review from johnstcn August 1, 2024 13:29
@mafredri
Copy link
Member Author

mafredri commented Aug 1, 2024

Rebased on main and amended PR feedback, ready for round 2.

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@@ -482,6 +503,26 @@ func (o *Options) Markdown() string {
return sb.String()
}

func (o *Options) CABundle() ([]byte, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach of hanging it off Options!

t.Run("OK", func(t *testing.T) {
// 2024/08/01 13:22:08 unsupported capability: shallow
// clone "http://127.0.0.1:41499": unexpected client error: unexpected requesting "http://127.0.0.1:41499/git-upload-pack" status code: 500
t.Skip("The gittest server doesn't support shallow cloning, skip for now...")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😿

@mafredri mafredri merged commit 9073748 into main Aug 1, 2024
4 checks passed
@mafredri mafredri deleted the mafredri/repo-mode branch August 1, 2024 15:07
johnstcn pushed a commit that referenced this pull request Aug 5, 2024
(cherry picked from commit 9073748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "repo-mode" to use the repo as source of truth for devcontainer/Dockerfile
2 participants