Supporting changes for envbuilder#234 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
approved these changes
Jun 24, 2024
pkg/util/fs_util.go
Outdated
| } | ||
|
|
||
| var defaultIgnoreList = []IgnoreListEntry{ | ||
| { | ||
| Path: filepath.Clean(config.KanikoDir), | ||
| PrefixMatchOnly: false, | ||
| AllowedPaths: make(map[string]struct{}), |
There was a problem hiding this comment.
nit: I would wrap IgnoreListEntry{} with NewIgnoreListEntry/CreateIgnoreListEntry, and set AllowedPaths there.
There was a problem hiding this comment.
It might actually be simpler to just use a []string instead; I don't anticipate having more than 10 entries here ever. Assigning to a nil map panics, while appending to / ranging over a nil slice is fine.
mtojek
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of coder/envbuilder#234