Skip to content

feat(jfrog-token): update module to accept username #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

joehutcheson
Copy link
Contributor

Description

Adds the options to specify a username for the Jfrog user as an input to the module.

This is useful in cases where Coder usernames and Jfrog usernames are different.

Test plan

Ran bun tests for the module.

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@matifali matifali merged commit 01d2c10 into coder:main Feb 18, 2025
2 checks passed
@joehutcheson joehutcheson deleted the jf-username branch February 19, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants