Skip to content

Revert "chore(jetbrans-gateway): update JetBrains IDEs" #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

spikecurtis
Copy link
Contributor

Reverts #96

Breaks dev.coder.com like

Error: Error in function call
on .terraform/modules/jetbrains_gateway/main.tf line 129, in resource "coder_app" "gateway":
  129:   display_name = data.coder_parameter.jetbrains_ide.option[index(data.coder_parameter.jetbrains_ide.option.*.value, data.coder_parameter.jetbrains_ide.value)].name
    ├────────────────
    │ data.coder_parameter.jetbrains_ide.option is list of object with 2 elements
    │ data.coder_parameter.jetbrains_ide.value is "[\"GO\",\"232.9921.53\",\"https://download.jetbrains.com/go/goland-2023.2.2.tar.gz\"]"
Call to function "index" failed: item not found.

@spikecurtis spikecurtis requested review from matifali, stirby and ericpaulsen and removed request for matifali November 14, 2023 06:41
@matifali
Copy link
Member

matifali commented Nov 14, 2023

@spikecurtis I am investigating why this breaks down the template as the changes are totally unrelated to the error we get.
This is again a strong point in favor of that we should have versioning for modules so that the updates don't break existing templates. See #70 for details.

@kylecarbs and @bpmct, I am adding versioning of modules as a must have for our registry integration GA milestone.

@matifali matifali closed this Nov 14, 2023
@matifali matifali reopened this Nov 14, 2023
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this to unblock everyone but will soon be merging the required fix.

@matifali matifali merged commit 4e7f1e0 into main Nov 14, 2023
@spikecurtis
Copy link
Contributor Author

I think what might have happened is that the registry was updated with new options, but the dogfood template still refers to the old versions in it's set of options.

@matifali
Copy link
Member

@spikecurtis If you see the change, we only use WS and GO on dogfood, but I removed PY and IC. So, it should not be related, apparently.

@matifali matifali deleted the revert-96-update-gateway branch November 14, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants