Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Japanese translations #194

Merged
merged 3 commits into from
Oct 23, 2019
Merged

add Japanese translations #194

merged 3 commits into from
Oct 23, 2019

Conversation

Tsumagari
Copy link
Contributor

#180 I added ja.json and /resources/lang/ja/validation.php

@kitbs
Copy link
Collaborator

kitbs commented Oct 16, 2019

どうもありがとう @Tsumagari
There are a few lines which have not been translated. Can you please fix them?

@Tsumagari
Copy link
Contributor Author

I'm very happy for your fast, kindly response!
I've forgotten that I left a few lines, I'll fix them soon!
Before that, can I ask you a question?
I wonder "Hold up!" means like "stop! (or, freeze!)" or so, but, could it be "lift (something)" ?
Which mean should I choose to translate?

@kitbs
Copy link
Collaborator

kitbs commented Oct 17, 2019

Thank you again for your work!

The "Hold up!" translation is used on the 403 error page along with the funny "The government won't let us show you what's behind these doors" message, so yes, it means something like "Stop!" or "Wait!" to tell the user they are not allowed to access that page.

@Tsumagari
Copy link
Contributor Author

I understand. I like these humor!
Thank you very much!

@kitbs kitbs merged commit 73261ec into coderello:master Oct 23, 2019
@garyross
Copy link

"Remember Me": "ログイン状態を保持", <-- this is better I think

Remember Me": "私を覚えておく", <-- this is a little odd for the functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants