Skip to content

Enable swapping the image processor via a setting #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

codingjoe
Copy link
Owner

To simplify customizations the image processort can be swapped.
Previously, it was necessary to override the PictureFieldFile.
Now, all that needs to be done is setting a custom value for
the PICTURES["PROCESSOR"] setting.

To simplify customizations the image processort can be swapped.
Previously, it was necessary to override the PictureFieldFile.
Now, all that needs to be done is setting a custom value for
the `PICTURES["PROCESSOR"]` setting.
@codingjoe codingjoe self-assigned this May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7088aac) 100.00% compared to head (47a6a29) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          446       446           
=========================================
  Hits           446       446           
Flag Coverage Δ
celery 85.65% <100.00%> (ø)
cleanup 86.32% <100.00%> (ø)
dj4.0 86.32% <100.00%> (ø)
dj4.1 86.32% <100.00%> (ø)
dramatiq 85.65% <100.00%> (ø)
drf 93.94% <100.00%> (ø)
macos-latest 86.54% <100.00%> (ø)
py3.10 86.32% <100.00%> (ø)
py3.11 86.32% <100.00%> (ø)
py3.8 86.32% <100.00%> (ø)
py3.9 86.32% <100.00%> (ø)
ubuntu-latest 86.32% <100.00%> (ø)
windows-latest 78.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pictures/conf.py 100.00% <ø> (ø)
pictures/models.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codingjoe codingjoe merged commit 9f0c956 into main May 24, 2023
@codingjoe codingjoe deleted the file-processor branch May 24, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant