Skip to content

Support Scala 2.11 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericacm opened this issue May 6, 2014 · 10 comments
Closed

Support Scala 2.11 #25

ericacm opened this issue May 6, 2014 · 10 comments
Assignees
Milestone

Comments

@ericacm
Copy link

ericacm commented May 6, 2014

No description provided.

nbauernfeind added a commit to nbauernfeind/scala-guice that referenced this issue May 7, 2014
@tsuckow
Copy link
Member

tsuckow commented May 14, 2014

I've been off the grid for a few days, I'll see about getting this built sometime this week.

@nbauernfeind
Copy link
Member

I have this working in a branch but trying to work out the migration from
type manifest to type tags.

We could merge in the changes to go 2.11 first, and I can work on the
migration of the deprecated api separately.
On May 13, 2014 10:07 PM, "Thomas Suckow" [email protected] wrote:

I've been off the grid for a few days, I'll see about getting this built
sometime this week.


Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-43037864
.

@tsuckow
Copy link
Member

tsuckow commented May 19, 2014

I was going to try and keep support for the older Scala versions on my
branch until 4.0 is released. Then probably merge your branch. I haven't
had time to re setup my build environment this week. Been preparing for a
memorial day backpacking trip. I am planning to dedicate tomorrow evening
to Scala-Guice.
On May 18, 2014 7:49 PM, "Nate Bauernfeind" [email protected]
wrote:

I have this working in a branch but trying to work out the migration from
type manifest to type tags.

We could merge in the changes to go 2.11 first, and I can work on the
migration of the deprecated api separately.
On May 13, 2014 10:07 PM, "Thomas Suckow" [email protected]
wrote:

I've been off the grid for a few days, I'll see about getting this built
sometime this week.


Reply to this email directly or view it on GitHub<
https://github.com/codingwell/scala-guice/issues/25#issuecomment-43037864>

.


Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-43462507
.

@tsuckow
Copy link
Member

tsuckow commented May 20, 2014

I am investigating a test failure in Google-Guice beta4

@tsuckow
Copy link
Member

tsuckow commented May 20, 2014

Appears they changed the behavior for multibindings in beta4, I'll have to update the unit tests and then continue pushing forward on a release supporting 2.11 and beta4.

@tsuckow tsuckow added this to the 4.0.0-beta4 milestone May 23, 2014
@tsuckow tsuckow self-assigned this May 23, 2014
@tsuckow
Copy link
Member

tsuckow commented May 23, 2014

Please look over https://github.com/codingwell/scala-guice/tree/release/4.0.0-beta4
https://travis-ci.org/codingwell/scala-guice/builds/25849915

If nothing seems horribly wrong I will try and publish next week

@diwa-zz
Copy link

diwa-zz commented May 25, 2014

Build seems to be successful.
It would be great to have a scala 2.11 version.

@nlochschmidt
Copy link

Any news on this? It's one of the very last dependencies holding us from going 2.11

@tsuckow
Copy link
Member

tsuckow commented May 29, 2014

So shall it be written, so shall 4.0.0-beta4 be released.

@nlochschmidt
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants