Remove support for scala 2.12 #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1010 +/- ##
==========================================
+ Coverage 83.66% 84.80% +1.13%
==========================================
Files 47 47
Lines 3172 3079 -93
Branches 454 491 +37
==========================================
- Hits 2654 2611 -43
+ Misses 518 468 -50 🚀 New features to boost your workflow:
|
Main reason to keep was to be compatible with Databricks But Databricks Runtime 16.3 should come early March and have support for 2.13&3 https://community.databricks.com/t5/data-engineering/when-will-db-release-runtime-with-scala-2-13/td-p/104399 https://docs.databricks.com/en/release-notes/runtime/index.html Note: not yet cleaning up code that could move to newer constructs not supported by 2.12
dmivankov
force-pushed
the
drop_scala_2.12
branch
from
5f74664 to
b7a13a0
Compare
|
This pull request seems a bit stale.. Shall we invite more to the party? |
dmivankov
added
the
waiting-for-risk-review
larshagencognite
added
risk-review-ongoing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main reason to keep was to be compatible with Databricks
Databricks Runtime 16.4 (LTS) is finally here and supports 2.13, starting 16.7 it won't support 2.12 at all, at some later point it should add scala3 support as spark 4+ will only support it
https://docs.databricks.com/aws/en/release-notes/runtime/16.4lts
Note: not yet cleaning up code that could move to newer constructs not supported by 2.12